Skip to content

Fix lfs version check warning log when using ssh protocol #5501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2018
Merged

Fix lfs version check warning log when using ssh protocol #5501

merged 2 commits into from
Dec 19, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 9, 2018

No description provided.

@lunny lunny mentioned this pull request Dec 9, 2018
Closed
7 tasks
@codecov-io
Copy link

Codecov Report

Merging #5501 into master will decrease coverage by <.01%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5501      +/-   ##
==========================================
- Coverage   37.63%   37.63%   -0.01%     
==========================================
  Files         317      317              
  Lines       46826    46827       +1     
==========================================
- Hits        17624    17621       -3     
- Misses      26701    26706       +5     
+ Partials     2501     2500       -1
Impacted Files Coverage Δ
routers/init.go 75.43% <100%> (+0.43%) ⬆️
modules/setting/setting.go 48.67% <56.25%> (+0.25%) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️
modules/sync/unique_queue.go 78.57% <0%> (-10.72%) ⬇️
routers/repo/view.go 44.78% <0%> (-1.23%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c0c965...3ae520b. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 9, 2018
lafriks
lafriks reviewed Dec 9, 2018
View reviewed changes
cmd/serv.go
setting.LFS.StartServer = false
println("LFS server support needs at least Git v2.1.2, disabled")
} else {
git.GlobalCommandArgs = append(git.GlobalCommandArgs, "-c", "filter.lfs.required=",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this require git-lfs on server?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unnecessary.

@lunny lunny added the type/bug label Dec 10, 2018
@lunny lunny added this to the 1.7.0 milestone Dec 10, 2018
@lunny lunny merged commit 7fd34c0 into go-gitea:master Dec 19, 2018
@lunny lunny deleted the lunny/fix_lfs_warn_log branch December 19, 2018 01:22
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks left review comments

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @lafriks @bkcsoft @techknowlogick