Skip to content

Update macaron session #5195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2018
Merged

Update macaron session #5195

merged 3 commits into from
Oct 30, 2018

Conversation

bkcsoft
Copy link
Member

@bkcsoft bkcsoft commented Oct 26, 2018 •
edited
Loading

backport of #5177

@bkcsoft bkcsoft added topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! backport/v1.6 labels Oct 26, 2018
@bkcsoft bkcsoft force-pushed the update-macaron-session-1.6 branch from 90736e5 to 6466ee1 Compare October 26, 2018 12:06
@bkcsoft bkcsoft changed the title Update macaron session for 1.6 Update macaron session Oct 26, 2018
@bkcsoft bkcsoft changed the base branch from master to release/v1.6 October 26, 2018 12:07
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 26, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 26, 2018
@techknowlogick
Copy link
Member

@go-gitea/owners will need to override that falied drone CI to merge.

@lunny
Copy link
Member

lunny commented Oct 29, 2018

Restart that CI cannot fix it.

@lunny lunny added this to the 1.6.0 milestone Oct 30, 2018
@lunny
Copy link
Member

lunny commented Oct 30, 2018

make L-G-T-M work

@lunny lunny merged commit 582213a into release/v1.6 Oct 30, 2018
@lafriks lafriks deleted the update-macaron-session-1.6 branch October 30, 2018 10:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+3 more reviewers

@sapk sapk sapk approved these changes

@jonasfranz jonasfranz jonasfranz approved these changes

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@bkcsoft @techknowlogick @lunny @sapk @jonasfranz @adelowo