Skip to content

Fix milestones sorted wrongly #4987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Fix milestones sorted wrongly #4987

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae31785
make sure milestone listing is consistent across board
adelowo Sep 27, 2018
6637e00
Merge branch 'master' of https://github.com/go-gitea/gitea into sort_…
adelowo Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/issue_milestone.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ func (milestones MilestoneList) getMilestoneIDs() []int64 {
// GetMilestonesByRepoID returns all milestones of a repository.
func GetMilestonesByRepoID(repoID int64) (MilestoneList, error) {
miles := make([]*Milestone, 0, 10)
return miles, x.Where("repo_id = ?", repoID).Find(&miles)
return miles, x.Where("repo_id = ?", repoID).Asc("deadline_unix").Find(&miles)
}

// GetMilestones returns a list of milestones of given repository and status.
Expand Down