Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Sep 26, 2018

Will resolve #3367

@lunny lunny added the type/enhancement An improvement of existing functionality label Sep 26, 2018
@lafriks lafriks added this to the 1.7.0 milestone Sep 26, 2018
@lunny lunny force-pushed the lunny/fix_dashboard branch from 1df90e7 to fbd4018 Compare October 26, 2018 02:29
@tonivj5
Copy link
Contributor

tonivj5 commented Nov 25, 2018

Is it ready to review? 👍 I'm having a lot of problems because of that 😢

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 25, 2018
@lunny
Copy link
Member Author

lunny commented Nov 26, 2018

@xxxTonixxx I will fix the tests failure.

@lunny lunny force-pushed the lunny/fix_dashboard branch from bccc203 to 69fcd79 Compare November 29, 2018 12:01
@lunny lunny force-pushed the lunny/fix_dashboard branch from 69fcd79 to 1a7e2bd Compare November 30, 2018 03:10
@codecov-io
Copy link

codecov-io commented Nov 30, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@49ea6e0). Click here to learn what that means.
The diff coverage is 43.52%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4977   +/-   ##
=========================================
  Coverage          ?   37.54%           
=========================================
  Files             ?      320           
  Lines             ?    47144           
  Branches          ?        0           
=========================================
  Hits              ?    17702           
  Misses            ?    26900           
  Partials          ?     2542
Impacted Files Coverage Δ
routers/api/v1/repo/pull.go 17.13% <0%> (ø)
models/issue_mail.go 12% <0%> (ø)
models/issue_tracked_time.go 67.56% <0%> (ø)
models/issue_stopwatch.go 71.05% <0%> (ø)
models/mail.go 1.72% <0%> (ø)
routers/repo/issue.go 36.88% <10%> (ø)
routers/user/home.go 41.88% <100%> (ø)
models/update.go 31.65% <100%> (ø)
routers/api/v1/repo/issue_comment.go 56.25% <11.11%> (ø)
routers/repo/pull.go 33.58% <19.04%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49ea6e0...3b4f795. Read the comment docs.

@lunny lunny mentioned this pull request Nov 30, 2018
7 tasks
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2018
@techknowlogick techknowlogick merged commit b3b7598 into go-gitea:master Dec 13, 2018
@lunny lunny deleted the lunny/fix_dashboard branch December 13, 2018 16:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

too slow when visit homepage( / )

7 participants