Skip to content

Conversation

techknowlogick
Copy link
Member

Fix #4200

@codecov-io
Copy link

codecov-io commented Jun 19, 2018

Codecov Report

Merging #4275 into master will increase coverage by 0.04%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4275      +/-   ##
==========================================
+ Coverage   19.97%   20.01%   +0.04%     
==========================================
  Files         153      153              
  Lines       30581    30584       +3     
==========================================
+ Hits         6109     6122      +13     
+ Misses      23544    23535       -9     
+ Partials      928      927       -1
Impacted Files Coverage Δ
models/models.go 33.05% <90.9%> (+3.86%) ⬆️
modules/process/manager.go 73.91% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93f138...8296849. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 19, 2018
@lunny
Copy link
Member

lunny commented Jun 19, 2018

@techknowlogick could you add some tests?

@lunny lunny added this to the 1.5.0 milestone Jun 19, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 19, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 19, 2018
@lafriks
Copy link
Member

lafriks commented Jun 19, 2018

@lunny I don't see how tests could be added for this

@techknowlogick
Copy link
Member Author

@lafriks / @lunny I could create a new function (similar to parsePostgreSQLHostPort) for generating postgres connection strings and test various variables for that.

I have a couple of hours until I can get started on that, but that's what I was thinking. Let me know what you think.

@techknowlogick
Copy link
Member Author

I pushed the function and now this is still pending tests.

@techknowlogick
Copy link
Member Author

Ok. Tests added, and I know this already has 2 LG-TM, but I will wait for another merger/owner to merge this.

@lafriks lafriks merged commit d84da8f into go-gitea:master Jun 20, 2018
@techknowlogick techknowlogick deleted the techknowlogick-patch-4 branch February 15, 2019 06:14
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

passwords with spaces seem to fail?

7 participants