Skip to content

Conversation

sapk
Copy link
Member

@sapk sapk commented Jun 11, 2018

Fix all the resting errors to have a valid swagger file.

They are still some warnings but nothing blocking.

Doing so I found that some request still misses son parameters for some POST/PUT/PATCH request. This means the a client generated from the swagger file will not work completely.

Fix #4088 by activating validation in drone
Should fix #4010.

@techknowlogick techknowlogick added type/docs This PR mainly updates/creates documentation topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Jun 11, 2018
@techknowlogick techknowlogick added this to the 1.6.0 milestone Jun 11, 2018
@codecov-io
Copy link

codecov-io commented Jun 11, 2018

Codecov Report

Merging #4220 into master will increase coverage by <.01%.
The diff coverage is 12.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4220      +/-   ##
==========================================
+ Coverage   19.96%   19.97%   +<.01%     
==========================================
  Files         153      153              
  Lines       30501    30514      +13     
==========================================
+ Hits         6091     6094       +3     
- Misses      23496    23506      +10     
  Partials      914      914
Impacted Files Coverage Δ
routers/api/v1/repo/issue_comment.go 0% <0%> (ø) ⬆️
routers/api/v1/repo/file.go 0% <0%> (ø) ⬆️
routers/api/v1/repo/hook.go 18.66% <0%> (-0.46%) ⬇️
routers/api/v1/repo/repo.go 0% <0%> (ø) ⬆️
routers/api/v1/repo/milestone.go 0% <0%> (ø) ⬆️
routers/api/v1/repo/issue_tracked_time.go 0% <0%> (ø) ⬆️
routers/api/v1/misc/markdown.go 82.53% <100%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba165e...c232a71. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 11, 2018
@sapk
Copy link
Member Author

sapk commented Jun 11, 2018

Ping @stevegt, if it can confirm that it solve #4010 to be used by his cli.

@sapk
Copy link
Member Author

sapk commented Jun 12, 2018

This one could maybe be in 1.5 milestone since it is only comments editing and that it can help use/generate swagger client. If not it will need to be backport I think.

@lafriks lafriks modified the milestones: 1.6.0, 1.5.0 Jun 12, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 12, 2018
@lunny
Copy link
Member

lunny commented Jun 12, 2018

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 12, 2018
@appleboy appleboy merged commit 908e894 into go-gitea:master Jun 12, 2018
@stevegt
Copy link
Contributor

stevegt commented Jun 12, 2018

Totally awesome @sapk! Thanks for the ping @bkcsoft! I'm leaving a conference right now, headed for the airport. Just pulled master so I can look while unplugged -- I was puzzling over the correct way to implement some of these fixes myself. This lets me get back to working on client side this week; will publish repos as I go. (/me is still in conference mode and can't remember if we already have a docs or other page for listing API clients...)

@sapk sapk mentioned this pull request Jun 12, 2018
@sapk sapk deleted the fix-swagger-errors branch June 12, 2018 23:42
stevegt added a commit to stevegt/gitea that referenced this pull request Jun 13, 2018
lunny pushed a commit that referenced this pull request Jun 15, 2018
* fixes a warning remaining from #4010 and #4220
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add swagger validate to drone run API fails swagger validation
8 participants