Skip to content

Conversation

@junoberryferry
Copy link
Contributor

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 9, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/dependencies labels Dec 9, 2025
@lunny lunny added this to the 1.26.0 milestone Dec 9, 2025
@lunny lunny changed the title Use AWS S3 SDK instead of Minio Use AWS S3 SDK instead of Minio Client SDK Dec 9, 2025
@silverwind
Copy link
Member

silverwind commented Dec 11, 2025

I think we should rename modules/storage/minio.* to modules/storage/s3.*. The PR diff for these two files should remain readable after such a rename.

@silverwind
Copy link
Member

silverwind commented Dec 12, 2025

Seems like I was wrong and GitHub's (or git's) move heuristic has split the diff of modules/storage/s3.go into two files. The proper diff can still be reviewed at this link:

https://github.com/go-gitea/gitea/pull/36118/changes/BASE..7064923a7d27181e0a22df8cb3073bbeee4eaf57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/dependencies modifies/go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants