Skip to content

Refactor legacy code, fix LFS auth bypass, fix symlink bypass (#35708) #35716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wxiaoguang merged 1 commit into from
Oct 21, 2025
Merged

Refactor legacy code, fix LFS auth bypass, fix symlink bypass (#35708) #35716

wxiaoguang merged 1 commit into from
Oct 21, 2025

Conversation

@GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Oct 21, 2025 •
edited by wxiaoguang
Loading

Backport #35708 by wxiaoguang

@wxiaoguang @GiteaBot
Refactor legacy code (go-gitea#35708)
592a6d7 
And by the way, remove the legacy TODO, split large functions into small
ones, and add more tests
@GiteaBot GiteaBot added modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code labels Oct 21, 2025
@GiteaBot GiteaBot added this to the 1.25.0 milestone Oct 21, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 21, 2025
@GiteaBot GiteaBot requested review from delvh and lunny October 21, 2025 05:19
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 21, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) October 21, 2025 05:20
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 21, 2025
@wxiaoguang wxiaoguang merged commit ac6d38e into go-gitea:release/v1.25 Oct 21, 2025
26 checks passed
@wxiaoguang wxiaoguang changed the title Refactor legacy code (#35708) Refactor legacy code, fix LFS auth bypass, fix symlink bypass (#35708) Oct 26, 2025
@wxiaoguang wxiaoguang added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Oct 26, 2025
@xnox xnox mentioned this pull request Dec 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees

@wxiaoguang wxiaoguang

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

4 participants

@GiteaBot @lunny @wxiaoguang @delvh