fix(webhook/discord): fixed username cannot be empty error #35412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… webhook username field is not required by discord so sending it as blank causes a 400 error. it should be omitted instead when it's not set. Closes go-gitea#35411
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Sep 5, 2025
GiteaBot
added
lgtm/need 1
techknowlogick
added
type/bug
backport/v1.24
lunny
approved these changes
Sep 5, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 5, 2025
…35412) username field is not required by discord and used to override the default username. sending it as blank causes a 400 error. it should be omitted instead when it's not set. Ref: https://discord.com/developers/docs/resources/webhook#execute-webhook-jsonform-params Closes go-gitea#35411
silverwind
pushed a commit
that referenced
this pull request
Sep 5, 2025
…35417) Backport #35412 by @ulnanlu username field is not required by discord and used to override the default username. sending it as blank causes a 400 error. it should be omitted instead when it's not set. Ref: https://discord.com/developers/docs/resources/webhook#execute-webhook-jsonform-params Closes #35411 Co-authored-by: ulnanlu <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 8, 2025
* giteaofficial/main: fix: add author.name field to Swift Package Registry API response (go-gitea#35410) Update js dependencies (go-gitea#35429) Support Node.js 22.6 with type stripping (go-gitea#35427) [skip ci] Updated translations via Crowdin apply as maintainer (go-gitea#35424) Upgrade golang to 1.25.1 and add descriptions for the swagger structs' fields (go-gitea#35418) Migrate tools and configs to typescript, require node.js >= 22.18.0 (go-gitea#35421) [skip ci] Updated translations via Crowdin Switch to `@resvg/resvg-wasm` for `generate-images` (go-gitea#35415) fix(webhook/discord): fixed username cannot be empty error (go-gitea#35412) add `/.pnpm-store` to .gitignore (go-gitea#35414)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
username field is not required by discord and used to override the default username. sending it as blank causes a 400 error. it should be omitted instead when it's not set.
Ref: https://discord.com/developers/docs/resources/webhook#execute-webhook-jsonform-params
Closes #35411