Skip to content

Fix submodule nil check #35096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2025
Merged

Fix submodule nil check #35096

merged 3 commits into from
Jul 16, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #35095

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 16, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jul 16, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jul 16, 2025
Closed
@wxiaoguang wxiaoguang added type/bug backport/v1.24 This PR should be backported to Gitea 1.24 labels Jul 16, 2025
@wxiaoguang wxiaoguang added this to the 1.25.0 milestone Jul 16, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 16, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 16, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) July 16, 2025 11:41
@wxiaoguang wxiaoguang merged commit fc4cb07 into go-gitea:main Jul 16, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-submoudle-nil branch July 16, 2025 12:09
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jul 16, 2025
@wxiaoguang @GiteaBot
Fix submodule nil check (go-gitea#35096)
e43c411 
Fix  go-gitea#35095
@GiteaBot GiteaBot mentioned this pull request Jul 16, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jul 16, 2025
wxiaoguang added a commit that referenced this pull request Jul 16, 2025
@GiteaBot @wxiaoguang
Fix submodule nil check (#35096) (#35098)
f99bbd7 
Backport #35096 by wxiaoguang

Fix  #35095

Co-authored-by: wxiaoguang <[email protected]>
@wxiaoguang wxiaoguang mentioned this pull request Jul 17, 2025
Merged
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 18, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
3ddb542 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Increase gap on latest commit (go-gitea#35104)
  Fix job status aggregation logic (go-gitea#35000)
  Fix some missed GitHeadRefName when renaming (go-gitea#35102)
  Fix error logs and improve some comments/messages (go-gitea#35105)
  Support Basic Authentication for archive downloads (go-gitea#35087)
  Run `uv run` with `--frozen` (go-gitea#35097)
  Improve package API log handling (go-gitea#35100)
  Rename pull request GetGitRefName to GetGitHeadRefName (go-gitea#35093)
  Fix review comment/dimiss comment x reference can be refereced back (go-gitea#35094)
  Fix submodule nil check (go-gitea#35096)
  Redirect to a presigned URL of HEAD for HEAD requests (go-gitea#35088)
wxiaoguang added a commit that referenced this pull request Jul 18, 2025
@wxiaoguang
Fix submodule parsing when the gitmodules is missing (#35109)
8f91bfe 
Follow up #35096, fix #35095, fix #35115 and add more tests

The old code used some fragile behaviors which depend on the "nil"
receiver. This PR should be a complete fix for more edge cases.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jul 18, 2025
@wxiaoguang @GiteaBot
Fix submodule parsing when the gitmodules is missing (go-gitea#35109)
37ea497 
Follow up go-gitea#35096, fix go-gitea#35095, fix go-gitea#35115 and add more tests

The old code used some fragile behaviors which depend on the "nil"
receiver. This PR should be a complete fix for more edge cases.
@GiteaBot GiteaBot mentioned this pull request Jul 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

PANIC: runtime error: invalid memory address or nil pointer dereference
4 participants
@wxiaoguang @silverwind @delvh @GiteaBot