Fixed all grammatical errors in locale_en-US.ini #35053
Conversation
GiteaBot
added
the
lgtm/need 2
|
Based upon casing, I wonder if the period additions for lines 323 and 353 is correct? 1038 and 1039 also read fine to me as they were; the original it's flows better than it is (IMO). 1105 has a url that should probably be URL to match the other instance. |
The period additions in 323 and 353 doesn't matter but i could remove them. |
|
I still see quite a few language issues in the file. The fixes in this PR are great but I would suggest to remove the "all" from the commit message when squashing and merging. Happy to contribute a separate PR after that's done to fix more of the issues. |
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
|
Hmm .... just found that the new text is too long for a "menu item" 🤣 
|
|
Hmmn. We can use "Block user from this organization" |
Yep, so your original "Block user from organization" should work |
|
Signed-off-by: wxiaoguang <[email protected]>
| @@ -358,7 +358,7 @@ no_reply_address = Hidden Email Domain | |||
| no_reply_address_helper = Domain name for users with a hidden email address. For example, the username 'joe' will be logged in Git as '[email protected]' if the hidden email domain is set to 'noreply.example.org'. | |||
| password_algorithm = Password Hash Algorithm | |||
| invalid_password_algorithm = Invalid password hash algorithm | |||
| password_algorithm_helper = Set the password hashing algorithm. Algorithms have differing requirements and strength. The argon2 algorithm is rather secure but uses a lot of memory and may be inappropriate for small systems. | |||
| password_algorithm_helper = Set the password hashing algorithm. Algorithms have differing requirements and strengths. The argon2 algorithm is rather secure but uses a lot of memory and may be inappropriate for small systems. | |||
There was a problem hiding this comment.
It depends on what is meant here.
"Algorithm A has this (qualitative) strength and algorithm B has that strength" → strengths
vs.
"Algorithms A and B differ in how strong they are" → strength
Based on the subsequent sentence, I guess it's more the first meaning.
* giteaofficial/main: Send email on Workflow Run Success/Failure (go-gitea#34982) [skip ci] Updated translations via Crowdin Replace `poetry` with `uv` (go-gitea#35084) nix flake update (go-gitea#35085) Use monospace font in PR command line instructions (go-gitea#35074) Add gitignore rules to exclude LLM instruction files (go-gitea#35076) [skip ci] Updated translations via Crowdin Fix form property assignment edge case (go-gitea#35073) Improve submodule relative path handling (go-gitea#35056) Fixed all grammatical errors in locale_en-US.ini (go-gitea#35053) UI: add hover background to table rows in user and repo admin page (go-gitea#35072)
This commit has the following: * partial port of changes from [gitea#35053](go-gitea/gitea#35053) ([corresponding WCP](https://codeberg.org/forgejo/forgejo/pulls/8591)) * some changes were applied * some strings we've fixed ourself before * some strings we don't have * a few fixes I wanted to propose but didn't want to dedicate a PR just to add a full stop to one string Co-authored-by: DJ Phoenix <[email protected]> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8593 Reviewed-by: Robert Wolff <[email protected]> Reviewed-by: Gusted <[email protected]>
No description provided.