Skip to content

Fix rendering of wiki page list if wiki repo contains other files #3454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 5, 2018
Merged

Fix rendering of wiki page list if wiki repo contains other files #3454

merged 3 commits into from
Feb 5, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Feb 4, 2018

Fixes #3453

@lafriks lafriks added this to the 1.4.0 milestone Feb 4, 2018
@codecov-io
Copy link

codecov-io commented Feb 4, 2018 •
edited
Loading

Codecov Report

Merging #3454 into master will decrease coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3454      +/-   ##
==========================================
- Coverage   35.67%   35.66%   -0.01%     
==========================================
  Files         281      281              
  Lines       40689    40697       +8     
==========================================
+ Hits        14514    14516       +2     
- Misses      24027    24032       +5     
- Partials     2148     2149       +1
Impacted Files Coverage Δ
routers/repo/wiki.go 43.95% <0%> (-0.45%) ⬇️
models/wiki.go 62.5% <100%> (ø) ⬆️
models/error.go 33.13% <60%> (+0.39%) ⬆️
modules/avatar/avatar.go 81.25% <0%> (-18.75%) ⬇️
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16c84d...1e98c0f. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 4, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 5, 2018
@lunny
Copy link
Member

lunny commented Feb 5, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 5, 2018
@lunny
Copy link
Member

lunny commented Feb 5, 2018

Should this be in v1.5.0 milestone?

@lafriks
Copy link
Member Author

lafriks commented Feb 5, 2018 •
edited
Loading

I don't think this should go to 1.5 as this needs to be backported to 1.4
@lunny yes, you ar right :)

@lafriks lafriks merged commit 283e87d into go-gitea:master Feb 5, 2018
@lafriks lafriks deleted the fix/wiki_page_list branch February 5, 2018 14:56
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Feb 5, 2018
@lafriks
Fix rendering of wiki page list if wiki repo contains other files (go…
84d03aa 
…-gitea#3454)

* Fix rendering of wiki page list if wiki repo contains other files

* Improve wiki filename tests
@lafriks lafriks mentioned this pull request Feb 5, 2018
Merged
@lafriks lafriks modified the milestones: 1.4.0, 1.5.0 Feb 5, 2018
@lafriks lafriks added the backport/done All backports for this PR have been created label Feb 5, 2018
lafriks added a commit that referenced this pull request Feb 6, 2018
@lafriks
Fix rendering of wiki page list if wiki repo contains other files (#3454
f61ef28 
) (#3463)

* Fix rendering of wiki page list if wiki repo contains other files

* Improve wiki filename tests
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Strange 500 error on wiki page
5 participants
@lafriks @codecov-io @lunny @appleboy @tboerger