Skip to content

Emoji Autocomplete #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lafriks merged 7 commits into from
Feb 3, 2018
Merged

Emoji Autocomplete #3433

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fe4be89
Implemented emoji autocomplete.
modmew8 Jan 30, 2018
cf877ae
Changed emoji access url.
modmew8 Jan 30, 2018
27c89bd
Reverted vendor css to default, moved all style changes to _tribute.less
modmew8 Jan 30, 2018
1f77796
Made no-results overwriteable, added missing autocomplete to edit iss…
modmew8 Jan 31, 2018
859c052
Replaced counter variable with array length.
modmew8 Jan 31, 2018
d466f99
Fixed wrong fmt.
modmew8 Jan 31, 2018
96d2f7f
Merge branch 'master' into emojiAutocomplete
lafriks Feb 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions public/vendor/plugins/tribute/tribute.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
display: inline-block;
vertical-align: middle;
width: 28px;
height: 28px;
Copy link
Member

@lafriks lafriks Jan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vendor css should not be changed. Instead create new rule in gitea style less file

Copy link
Contributor Author

@modmew8 modmew8 Jan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vendor css has apparently already been altered, if you take a look at the original repo:
https://github.com/zurb/tribute/blob/master/dist/tribute.css

Then we should reset it to default and transport the changes been done to the gitea style less file as well.

margin-right: 5px;
}
.tribute-container li span {
Expand Down
31 changes: 31 additions & 0 deletions templates/base/footer.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,37 @@
issuesTribute.attach(document.getElementById('content'))
</script>
{{end}}
<script>
Copy link
Member

@kolaente kolaente Jan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to not put this in /public/js/index.js?

Copy link
Member

@lafriks lafriks Jan 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolaente it can't be put (at least currently) in index.js as it has server-side condition check if this should be included so such refactoring would probably be better done in different PR

Copy link
Contributor Author

@modmew8 modmew8 Jan 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried putting it to /public/js/index.js, and limited the initialization of tribute to a condition, wether an element with id content is available.

But I think it is much cleaner, if the emojiTribute is only initialized when the page requiring it is loaded.

Copy link
Member

@kolaente kolaente Jan 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok I see...

var emojiTribute = new Tribute({
trigger: ':',
values: function (text, cb) {
var array = emojify.emojiNames;
var data = [];
var counter = 0;
for(var j=0; j<array.length; j++) {
Copy link
Member

@lafriks lafriks Jan 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just use j < Math.min(array.length, 5) and than you don't need counter variable and condition below with break.

Copy link
Member

@daviian daviian Jan 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there should be 6 elements in the data array, which is not always the case in a loop to 5 because of the if condition.
Instead of the counter the break could be done by condition data.length > 5?

Copy link
Contributor Author

@modmew8 modmew8 Jan 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this loop is used to limit the amount of results to a maximum of 6 - but traverses all emojiNames using j. Removing the counter and replacing the condition with data.length >5 looks much better to me. Thanks @daviian

if(array[j].indexOf(text) !== -1) {
data.push(array[j]);
counter++;
if(counter > 5) {
break;
}
}
}
cb(data);
},
lookup: function (item) {
return item;
},
selectTemplate: function (item) {
if (typeof item === 'undefinied') return null;
return ':' + item.original + ':';
},
menuItemTemplate: function (item) {
return '<img class="emoji" src="{{AppSubUrl}}/vendor/plugins/emojify/images/' + item.original + '.png"/>' + item.original;
}
});
emojiTribute.attach(document.getElementById('content'))
</script>
{{end}}
<script src="{{AppSubUrl}}/vendor/plugins/autolink/autolink.js"></script>
<script src="{{AppSubUrl}}/vendor/plugins/emojify/emojify.min.js"></script>
Expand Down