Skip to content

Improve "not found" error messages for API #34267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Improve "not found" error messages for API #34267

merged 1 commit into from
Apr 23, 2025

Conversation

wxiaoguang
Copy link
Contributor

Make the message clear, for example: #34266

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 23, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Apr 23, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Apr 23, 2025
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 23, 2025
@wxiaoguang wxiaoguang changed the title Improvoe "not found" error messages for API Improve "not found" error messages for API Apr 23, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 23, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 23, 2025
@wxiaoguang wxiaoguang merged commit 8aee07a into go-gitea:main Apr 23, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-api-msg branch April 23, 2025 09:42
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 24, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
319a1c2 
* giteaofficial/main:
  Fix panic when comment is nil (go-gitea#34257)
  Fix various trivial frontend problems (go-gitea#34263)
  update go&js dependencies (go-gitea#34262)
  Fix runner list tmpl (go-gitea#34270)
  Improve "not found" error messages for API (go-gitea#34267)
  Add fullscreen mode as a more efficient operation way to view projects (go-gitea#34081)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metiftikci metiftikci metiftikci approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @metiftikci @hiifong @GiteaBot