Skip to content

Use correct translation key for delete email button #3422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2018
Merged

Use correct translation key for delete email button #3422

merged 2 commits into from
Jan 30, 2018

Conversation

@lafriks
Copy link
Member

@lafriks lafriks commented Jan 28, 2018

Also fix spacing

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Jan 28, 2018
@codecov-io
Copy link

codecov-io commented Jan 28, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b3fd94c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3422   +/-   ##
=========================================
  Coverage          ?   35.61%           
=========================================
  Files             ?      281           
  Lines             ?    40586           
  Branches          ?        0           
=========================================
  Hits              ?    14455           
  Misses            ?    23992           
  Partials          ?     2139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3fd94c...8524eca. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 28, 2018
@lafriks lafriks changed the title Use correct transaltion key for delete email button Use correct translation key for delete email button Jan 28, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 29, 2018
@thehowl
Copy link
Contributor

thehowl commented Jan 30, 2018

if anyone else wants to review: remember that ?w=1 is your best friend. LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2018
@lafriks lafriks added this to the 1.4.0 milestone Jan 30, 2018
@lafriks lafriks merged commit f9a5cc4 into go-gitea:master Jan 30, 2018
@lafriks lafriks deleted the fix/use_delete_email_tr branch January 30, 2018 22:31
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ethantkoenig ethantkoenig ethantkoenig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lafriks @codecov-io @thehowl @ethantkoenig @tboerger