Skip to content

Fix race condition in repo renaming #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2018
Merged

Fix race condition in repo renaming #3418

merged 3 commits into from
Jan 28, 2018

Conversation

@ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Jan 28, 2018

@codecov-io
Copy link

codecov-io commented Jan 28, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@c55a027). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3418   +/-   ##
=========================================
  Coverage          ?   35.61%           
=========================================
  Files             ?      281           
  Lines             ?    40589           
  Branches          ?        0           
=========================================
  Hits              ?    14456           
  Misses            ?    23995           
  Partials          ?     2138
Impacted Files Coverage Δ
models/repo.go 43.17% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c55a027...a85bebf. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 28, 2018
@lafriks lafriks added this to the 1.4.0 milestone Jan 28, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 28, 2018
@lafriks lafriks merged commit bac6ac0 into go-gitea:master Jan 28, 2018
@ethantkoenig ethantkoenig deleted the fix/rename_race_cond branch January 28, 2018 16:37
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@Bwko Bwko Bwko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ethantkoenig @codecov-io @lafriks @Bwko @tboerger