Skip to content

Fix bug when generating repository #34149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix bug when generating repository #34149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion services/repository/template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ func GenerateRepository(ctx context.Context, doer, owner *user_model.User, templ
}()

// 2 - check whether the repository with the same storage exists
isExist, err := gitrepo.IsRepositoryExist(ctx, generateRepo)
var isExist bool
isExist, err = gitrepo.IsRepositoryExist(ctx, generateRepo)
Copy link
Contributor

@wxiaoguang wxiaoguang Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think it is a bug

Copy link
Member Author

@lunny lunny Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 103 will check if err is nil. Since the directory exist, we need to cleanupReposioty, so that this err should be the returned parameter but not a local variable.

Copy link
Contributor

@wxiaoguang wxiaoguang Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show me why


func TestError(t *testing.T) {
	f := func(t *testing.T) (err error) {
		defer func() {
			assert.ErrorContains(t, err, "error")
		}()
		val, err := 1, nil
		_ = val
		_ = err
		assert.NoError(t, err)
		return errors.New("error")
	}
	assert.ErrorContains(t, f(t), "error")
}

Copy link
Member Author

@lunny lunny Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I see. The return will assign the error to the returned parameter err.

if err != nil {
log.Error("Unable to check if %s exists. Error: %v", generateRepo.FullName(), err)
return nil, err
Expand Down