Skip to content

Enhance routers for the Actions variable operations (#33547) #33553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 11, 2025

Backport #33547

  • Find the variable before updating or deleting
  • Move the main logic from routers/web/repo/setting/variables.go to routers/web/shared/actions/variables.go.

- Find the variable before updating or deleting
- Move the main logic from `routers/web/repo/setting/variables.go` to
`routers/web/shared/actions/variables.go`.

---------

Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot added this to the 1.23.4 milestone Feb 11, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 11, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Feb 11, 2025
@lunny lunny requested review from wxiaoguang and wolfogre February 11, 2025 03:12
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 11, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 11, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) February 11, 2025 03:29
@wxiaoguang wxiaoguang merged commit 7c17d0a into go-gitea:release/v1.23 Feb 11, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the lunny/backport_33547 branch February 11, 2025 04:07
@go-gitea go-gitea locked as resolved and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants