Fix editor markdown not incrementing in a numbered list #33187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
harryvince
force-pushed
the
main
branch
6 times, most recently
from
cd32276 to
fd815c8
Compare
harryvince
changed the title
wxiaoguang
reviewed
Jan 10, 2025
|
I will try to make a full fix here, to handle all edge cases including: |
|
Now most edge cases should have been fixed, and added more tests |
wxiaoguang
approved these changes
Jan 10, 2025
GiteaBot
removed
the
lgtm/need 2
GiteaBot
added
the
lgtm/need 1
Merged
lunny
approved these changes
Jan 10, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Jan 10, 2025
Amended the logic for newPrefix in the MarkdownEditor to resolve incorrect number ordering. Fixes go-gitea#33184 Attached screenshot of fixed input similar to issue <img width="175" alt="Screenshot 2025-01-09 at 23 59 24" src="https://github.com/user-attachments/assets/dfa23cf1-f3db-4b5e-99d2-a71bbcb289a8" /> --------- Co-authored-by: wxiaoguang <[email protected]>
lunny
pushed a commit
that referenced
this pull request
Jan 10, 2025
) Backport #33187 (no conflict) Co-authored-by: Harry Vince <[email protected]>
GiteaBot
added
the
backport/manual
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 14, 2025
* giteaofficial/main: (21 commits) Support public code/issue access for private repositories (go-gitea#33127) Validate that the tag doesn't exist when creating a tag via the web (go-gitea#33241) [skip ci] Updated translations via Crowdin Switch back to `vue-tsc` (go-gitea#33248) Let API create and edit system webhooks, attempt 2 (go-gitea#33180) Fix incorrect ref "blob" (go-gitea#33240) Refactor RefName (go-gitea#33234) Refactor context RefName and RepoAssignment (go-gitea#33226) [skip ci] Updated translations via Crowdin Fix upload file form (go-gitea#33230) Fix mirror bug (go-gitea#33224) Remove unused CSS styles and move some styles to proper files (go-gitea#33217) Refactor context repository (go-gitea#33202) [skip ci] Updated translations via Crowdin Fix unpin hint on the pinned pull requests (go-gitea#33207) fix(cache): cache test triggered by non memory cache (go-gitea#33220) Update README.md (go-gitea#33149) Fix editor markdown not incrementing in a numbered list (go-gitea#33187) Some small refactors (go-gitea#33144) Fix sync fork for consistency (go-gitea#33147) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amended the logic for newPrefix in the MarkdownEditor to resolve incorrect number ordering.
Fixes #33184
Attached screenshot of fixed input similar to issue
