Fix JS regression from 32656 #32670
Closed
Fix JS regression from 32656 #32670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: justusbunsi <[email protected]>
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Actually that change was from @silverwind (discussions: #32647 (comment) and #32656 (comment) )
(and to be honest ...... I do not really like it, see my comment #32660 (comment))
wxiaoguang
added
the
issue/needs-feedback
I think this has been resolved by #32661, after upgrading gitea.com. It has been fixed. @justusbunsi |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32656 seem to cause a JavaScript error when visiting https://gitea.com/gitea/helm-chart/pulls/239.
processis undefined. Only occurs when logged in.This should fix it.