Skip to content

Conversation

ethantkoenig
Copy link
Member

Remove code in TransferOwnership which decrements teams' number of repos, since that is already done by the removeOrgRepo(..) method. Also adds a unit test for a TransferOwnership.

@codecov-io
Copy link

codecov-io commented Dec 20, 2017

Codecov Report

Merging #3241 into master will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3241      +/-   ##
==========================================
+ Coverage   34.67%   34.95%   +0.27%     
==========================================
  Files         277      277              
  Lines       40014    40004      -10     
==========================================
+ Hits        13876    13982     +106     
+ Misses      24134    23982     -152     
- Partials     2004     2040      +36
Impacted Files Coverage Δ
models/repo.go 43.39% <ø> (+1.92%) ⬆️
models/repo_indexer.go 50.97% <0%> (-0.98%) ⬇️
models/action.go 65.11% <0%> (+0.22%) ⬆️
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️
models/lfs.go 28.26% <0%> (+2.17%) ⬆️
modules/lfs/server.go 35.01% <0%> (+14.32%) ⬆️
modules/lfs/content_store.go 43.75% <0%> (+35.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf17e3...3d19100. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 20, 2017
@lunny lunny added this to the 1.4.0 milestone Dec 20, 2017
@lunny
Copy link
Member

lunny commented Dec 20, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 20, 2017
@lunny
Copy link
Member

lunny commented Dec 20, 2017

will fix #3233

@lafriks
Copy link
Member

lafriks commented Dec 20, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 20, 2017
@lunny lunny merged commit e67b405 into go-gitea:master Dec 20, 2017
@lafriks
Copy link
Member

lafriks commented Dec 20, 2017

@ethantkoenig please backport

ethantkoenig added a commit to ethantkoenig/gitea that referenced this pull request Dec 20, 2017
@ethantkoenig ethantkoenig deleted the fix/team_num_repos branch December 30, 2017 16:20
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants