Skip to content

Refactor spelling of JavaScript licenses in footer #3224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2017
Merged

Refactor spelling of JavaScript licenses in footer #3224

merged 2 commits into from
Dec 19, 2017

Conversation

jsstrn
Copy link
Contributor

@jsstrn jsstrn commented Dec 18, 2017

Spell JavaScript licenses in footer with an uppercase 'S'

Reference: Mozilla

@jsstrn
Use correct camel casing for JavaScript
f8c9bbe 
JavaScript should be spelt with an uppercase 'S' as per seen in [Mozilla](https://developer.mozilla.org/en-US/docs/Web/JavaScript)
@codecov-io
Copy link

codecov-io commented Dec 18, 2017 •
edited
Loading

Codecov Report

Merging #3224 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3224      +/-   ##
==========================================
- Coverage   34.87%   34.86%   -0.02%     
==========================================
  Files         277      277              
  Lines       40014    40014              
==========================================
- Hits        13955    13949       -6     
- Misses      24038    24042       +4     
- Partials     2021     2023       +2
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo.go 41.28% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e384c6...174201e. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 18, 2017
@lafriks
Copy link
Member

lafriks commented Dec 18, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 18, 2017
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Dec 18, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 18, 2017
@sapk
Copy link
Member

sapk commented Dec 18, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 18, 2017
@lunny lunny merged commit 1123313 into go-gitea:master Dec 19, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jsstrn @codecov-io @lafriks @sapk @lunny @tboerger