Skip to content

Check ignored errors for issue and milestone count #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2017
Merged

Check ignored errors for issue and milestone count #3213

merged 2 commits into from
Dec 18, 2017

Conversation

ethantkoenig
Copy link
Member

Check previously-ignored errors in issue_milestone.go

@lafriks
Copy link
Member

lafriks commented Dec 17, 2017

CI build failed

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 17, 2017
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 17, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 17, 2017
@codecov-io
Copy link

Codecov Report

Merging #3213 into master will decrease coverage by 0.01%.
The diff coverage is 48.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3213      +/-   ##
==========================================
- Coverage   34.69%   34.68%   -0.02%     
==========================================
  Files         277      277              
  Lines       39990    40014      +24     
==========================================
+ Hits        13876    13879       +3     
- Misses      24116    24132      +16     
- Partials     1998     2003       +5
Impacted Files Coverage Δ
routers/repo/issue.go 32.78% <0%> (-0.12%) ⬇️
models/issue_milestone.go 57.8% <55.88%> (-3.03%) ⬇️
models/repo_list.go 65.62% <0%> (-1.57%) ⬇️
models/repo.go 41.47% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0e2a8...f23a649. Read the comment docs.

@lafriks
Copy link
Member

lafriks commented Dec 17, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 17, 2017
@sapk
Copy link
Member

sapk commented Dec 18, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 18, 2017
@lafriks lafriks merged commit 0e384c6 into go-gitea:master Dec 18, 2017
@lafriks lafriks changed the title Check ignored errors Check ignored errors for issue and milestone count Dec 18, 2017
@ethantkoenig ethantkoenig deleted the fix/ignored_errs branch January 13, 2018 20:37
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ethantkoenig @lafriks @codecov-io @sapk @tboerger