Skip to content

Fix Bug in Issue/pulls list #32081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 23, 2024
Merged

Fix Bug in Issue/pulls list #32081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d0a3438
Fix Assign appropriate value to ctx.Data[IsShowClosed] according to t…
cloudchamb3r Sep 19, 2024
b49950a
Merge branch 'main' into fix/issues-is-show-closed
cloudchamb3r Sep 20, 2024
f01c87b
make it handle optional IsShowClosed in issues/pulls list in filter_a…
cloudchamb3r Sep 20, 2024
0fc078c
Merge branch 'main' into fix/issues-is-show-closed
cloudchamb3r Sep 20, 2024
d55a5ed
Merge branch 'fix/issues-is-show-closed' of https://github.com/cloudc…
cloudchamb3r Sep 20, 2024
a3e2beb
remove unncessary spaces
cloudchamb3r Sep 20, 2024
10fb60d
Merge branch 'main' into fix/issues-is-show-closed
lunny Sep 22, 2024
0609849
Merge branch 'main' into fix/issues-is-show-closed
cloudchamb3r Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions routers/web/repo/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,7 @@ func issues(ctx *context.Context, milestoneID, projectID int64, isPullOption opt
ctx.Data["AssigneeID"] = assigneeID
ctx.Data["PosterID"] = posterID
ctx.Data["Keyword"] = keyword
ctx.Data["IsShowClosed"] = isShowClosed
switch {
case isShowClosed.Value():
ctx.Data["State"] = "closed"
Expand Down
4 changes: 2 additions & 2 deletions templates/repo/issue/filter_actions.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<div class="ui secondary filter menu">
{{if not .Repository.IsArchived}}
<!-- Action Button -->
{{if .IsShowClosed}}
{{if and .IsShowClosed.Has .IsShowClosed.Value}}
<button class="ui primary basic button issue-action" data-action="open" data-url="{{$.RepoLink}}/issues/status">{{ctx.Locale.Tr "repo.issues.action_open"}}</button>
{{else}}
{{else if and .IsShowClosed.Has (not .IsShowClosed.Value)}}
<button class="ui red basic button issue-action" data-action="close" data-url="{{$.RepoLink}}/issues/status">{{ctx.Locale.Tr "repo.issues.action_close"}}</button>
{{end}}
{{if $.IsRepoAdmin}}
Expand Down
Loading