Skip to content

Conversation

@lafriks
Copy link
Member

@lafriks lafriks commented Dec 11, 2017

Related to #3157

@lafriks lafriks added this to the 1.4.0 milestone Dec 11, 2017
@sapk
Copy link
Member

sapk commented Dec 11, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 11, 2017
@lafriks
Copy link
Member Author

lafriks commented Dec 12, 2017

Real changes are only in first commit, second has only file name renames to match real migration version

@codecov-io
Copy link

codecov-io commented Dec 12, 2017

Codecov Report

Merging #3160 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3160      +/-   ##
==========================================
- Coverage   34.52%   34.51%   -0.01%     
==========================================
  Files         276      276              
  Lines       39970    39974       +4     
==========================================
- Hits        13800    13798       -2     
- Misses      24192    24198       +6     
  Partials     1978     1978
Impacted Files Coverage Δ
models/migrations/migrations.go 2.89% <0%> (-0.02%) ⬇️
models/migrations/v53.go 0% <0%> (ø)
models/migrations/v50.go 0% <0%> (ø) ⬆️
models/migrations/v52.go 0% <0%> (ø)
models/migrations/v51.go 0% <0%> (ø)
models/migrations/v49.go 0% <0%> (ø) ⬆️
models/migrations/v45.go 0% <0%> (ø) ⬆️
models/migrations/v40.go 0% <0%> (ø) ⬆️
models/migrations/v41.go 0% <0%> (ø) ⬆️
models/migrations/v39.go 0% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c5911...8105566. Read the comment docs.

@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 13, 2017
@lafriks lafriks merged commit c06cc74 into go-gitea:master Dec 13, 2017
@lafriks lafriks deleted the fix/migration_order branch December 13, 2017 14:52
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants