Skip to content

Fix Uninitialized variable in ParsePatch #3156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

bkcsoft
Copy link
Member

@bkcsoft bkcsoft commented Dec 11, 2017

Fix a bug reported on Discord.

top of stack trace:

    [Macaron] PANIC: runtime error: invalid memory address or nil pointer dereference
    /usr/local/go/src/runtime/panic.go:489 (0x428a6a)
    /usr/local/go/src/runtime/panic.go:63 (0x427c0c)
    /usr/local/go/src/runtime/signal_windows.go:161 (0x43a624)
    /srv/app/src/code.gitea.io/gitea/models/git_diff.go:350 (0xb5eb8f)
    /srv/app/src/code.gitea.io/gitea/models/git_diff.go:495 (0xb609b9)
    /srv/app/src/code.gitea.io/gitea/models/git_diff.go:564 (0xb614e1)
    /srv/app/src/code.gitea.io/gitea/routers/repo/commit.go:213 (0xca6979)

Bug in https://github.com/go-gitea/gitea/blob/release/v1.3/models/git_diff.go#L341 because https://github.com/go-gitea/gitea/blob/release/v1.3/models/git_diff.go#L241 is never initialized.

@codecov-io
Copy link

Codecov Report

Merging #3156 into master will decrease coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3156     +/-   ##
=========================================
- Coverage   34.73%   34.54%   -0.2%     
=========================================
  Files         276      276             
  Lines       39945    39945             
=========================================
- Hits        13875    13798     -77     
- Misses      24074    24169     +95     
+ Partials     1996     1978     -18
Impacted Files Coverage Δ
models/git_diff.go 60.16% <100%> (ø) ⬆️
modules/lfs/content_store.go 7.81% <0%> (-35.94%) ⬇️
modules/lfs/server.go 20.68% <0%> (-14.33%) ⬇️
models/lfs.go 26.08% <0%> (-2.18%) ⬇️
models/repo_list.go 65.62% <0%> (-1.57%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b525d5...1795873. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 11, 2017
@lafriks
Copy link
Member

lafriks commented Dec 11, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2017
@lafriks
Copy link
Member

lafriks commented Dec 11, 2017

@bkcsoft please use forked repo ;)

@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2017
@lafriks lafriks merged commit 4b5197b into master Dec 12, 2017
@lafriks lafriks deleted the parse-patch-uninitialized-var branch December 12, 2017 00:32
lafriks pushed a commit to lafriks-fork/gitea that referenced this pull request Dec 12, 2017
@lafriks lafriks added the backport/done All backports for this PR have been created label Dec 12, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants