Skip to content

Conversation

svarlamov
Copy link
Contributor

Signed-off-by: Sasha Varlamov [email protected]

Targeting: #3095

@svarlamov
Copy link
Contributor Author

I see that the built-in autolink is breaking the custom parsing... Should we copy-paste the auto-link algo into the Gitea link func?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 7, 2017
@andrew-boyarshin
Copy link
Contributor

@svarlamov I didn't remove AUTOLINK extension for nothing in #186. It broke things. So instead a frontend is now responsible for calling $(...).autolink() function. If you discover a way to fix autolinking without corrupting DOM on server and without doing sth monstrous like DOM tree parsing in Go, it would be very welcome.

@svarlamov
Copy link
Contributor Author

@andrew-boyarshin Thank you for pointing out the reasoning behind this... I see that it's happening client-side now... I haven't looked into the autolink function of blackfriday yet, so I will start there. If that's too big, then I think that there might be a simpler client-side fix -- something jquery-based

@lunny
Copy link
Member

lunny commented Jan 16, 2018

This should be closed by #3354

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants