Skip to content

Fixed remaining linting errors #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 29, 2016
Merged

Fixed remaining linting errors #303

merged 4 commits into from
Nov 29, 2016

Conversation

tboerger
Copy link
Member

@tboerger tboerger commented Nov 29, 2016 •
edited
Loading

  • Fix general linting errors
  • Fix bindata linting errors
  • Integrate lint check into drone

@tboerger tboerger added this to the 1.0.0 milestone Nov 29, 2016
bkcsoft
bkcsoft suggested changes Nov 29, 2016
View reviewed changes
Copy link
Member

@bkcsoft bkcsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little thing

Makefile
@@ -131,6 +131,8 @@ bindata: modules/bindata/bindata.go
modules/bindata/bindata.go: $(BINDATA)
go-bindata -o=$@ -ignore="\\.go|README.md|TRANSLATORS" -pkg=bindata conf/...
go fmt $@
sed -i.bak 's/confLocaleLocale_/confLocaleLocale/' $@
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to sed -i '' 's/......, works on linux,freebsd,macos :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, that won't work on linux, at least not on Alpine.

sed -i '' 's/confLocaleLocale_/confLocaleLocale/' modules/bindata/bindata.go
sed: s/confLocaleLocale_/confLocaleLocale/: No such file or directory

@Bwko
Copy link
Member

Bwko commented Nov 29, 2016

Except for ^ LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 29, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Nov 29, 2016

sed apparently isn't cross-platform friendly so screw it. LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2016
@tboerger tboerger merged commit 4680c34 into go-gitea:master Nov 29, 2016
@tboerger tboerger deleted the linting branch November 29, 2016 14:18
@lunny lunny mentioned this pull request Nov 29, 2016
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@bkcsoft bkcsoft bkcsoft approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tboerger @Bwko @bkcsoft