Skip to content

Conversation

@techknowlogick
Copy link
Member

Gitea now has a forum which is probably a better venue for these types of conversations

Gitea now has a forum which is probably a better venue for
these types of conversations
@codecov-io
Copy link

codecov-io commented Nov 28, 2017

Codecov Report

Merging #3015 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3015      +/-   ##
==========================================
+ Coverage   32.98%   33.02%   +0.03%     
==========================================
  Files         270      270              
  Lines       39534    39534              
==========================================
+ Hits        13042    13055      +13     
+ Misses      24637    24629       -8     
+ Partials     1855     1850       -5
Impacted Files Coverage Δ
models/repo.go 38% <0%> (+0.18%) ⬆️
models/repo_indexer.go 49% <0%> (+3.46%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbc6bbf...43b3cea. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 28, 2017
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Nov 28, 2017
@lunny
Copy link
Member

lunny commented Nov 29, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 29, 2017
@lunny lunny added this to the 1.4.0 milestone Nov 29, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2017
@lunny lunny merged commit dab2b35 into go-gitea:master Nov 29, 2017
lafriks pushed a commit to lafriks-fork/gitea that referenced this pull request Nov 29, 2017
Gitea now has a forum which is probably a better venue for
these types of conversations
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants