Skip to content

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Nov 27, 2017

fixes docker build from: #2874

drone-docker plugin uses the base dir as context even when referring to other Dockerfiles in different dir

@codecov-io
Copy link

codecov-io commented Nov 27, 2017

Codecov Report

Merging #2989 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2989      +/-   ##
==========================================
+ Coverage   32.48%   32.51%   +0.02%     
==========================================
  Files         267      267              
  Lines       39271    39271              
==========================================
+ Hits        12759    12769      +10     
+ Misses      24720    24714       -6     
+ Partials     1792     1788       -4
Impacted Files Coverage Δ
models/repo.go 38% <0%> (+0.18%) ⬆️
models/repo_indexer.go 49% <0%> (+3.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1028ef2...de4e434. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 27, 2017
@lunny lunny added this to the 1.4.0 milestone Nov 27, 2017
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Nov 27, 2017
@lunny
Copy link
Member

lunny commented Nov 27, 2017

I think maybe add a route /docs to the folder and link Help to self /docs.

@techknowlogick
Copy link
Member Author

Thanks for feedback @lunny

For this PR I'm just trying to keep it as simple as I can to fix this build when on master branch: https://drone.gitea.io/go-gitea/gitea/2031/17

@lunny
Copy link
Member

lunny commented Nov 27, 2017

@techknowlogick That's OK. That could be done by future PRs.

@lafriks
Copy link
Member

lafriks commented Nov 27, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 27, 2017
@lunny
Copy link
Member

lunny commented Nov 27, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 27, 2017
@lafriks lafriks merged commit 6a58e3f into go-gitea:master Nov 27, 2017
@lafriks
Copy link
Member

lafriks commented Nov 27, 2017

@techknowlogick still failing :(

@techknowlogick techknowlogick deleted the patch-3 branch November 27, 2017 14:33
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants