Skip to content

Prevent layout shift in <overflow-menu> items #29831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 20, 2024
Merged

Prevent layout shift in <overflow-menu> items #29831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c8a2963
Prevent layout shift from active `<overflow-menu>` items
silverwind Mar 15, 2024
b67ea62
use variable change to 600
silverwind Mar 16, 2024
6b87b4b
use semibold, reduce padding
silverwind Mar 16, 2024
72d0912
merge related css rules for menus
silverwind Mar 16, 2024
2a82c3e
add margin to repo-header
silverwind Mar 16, 2024
a323e19
Update web_src/css/base.css
silverwind Mar 17, 2024
2f67b41
Update web_src/css/base.css
silverwind Mar 17, 2024
7b4e0ca
Update web_src/js/webcomponents/overflow-menu.js
silverwind Mar 19, 2024
a5845f5
Merge branch 'main' into noshift
silverwind Mar 19, 2024
a21fabb
tweak and add comment
silverwind Mar 19, 2024
b48978d
rename to resize-for-semibold
silverwind Mar 20, 2024
b995486
Merge remote-tracking branch 'origin/main' into noshift
silverwind Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions web_src/css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1778,15 +1778,6 @@ table th[data-sortt-desc] .svg {
border-color: var(--color-secondary);
}

.ui.tabular.menu .item {
padding: 11px 12px;
color: var(--color-text-light-2);
}

.ui.tabular.menu .item:hover {
color: var(--color-text);
}

.ui.tabular.menu .active.item,
.ui.tabular.menu .active.item:hover {
background: var(--color-body);
Expand All @@ -1803,17 +1794,36 @@ table th[data-sortt-desc] .svg {
border-color: var(--color-secondary);
}

.ui.tabular.menu .item,
.ui.secondary.pointing.menu .item {
padding: 11px 12px !important;
color: var(--color-text-light-2);
}

.ui.tabular.menu .item:hover,
.ui.secondary.pointing.menu a.item:hover {
color: var(--color-text);
}

.ui.secondary.pointing.menu .active.item,
.ui.secondary.pointing.menu .active.item:hover,
.ui.secondary.pointing.menu .dropdown.item:hover,
.ui.secondary.pointing.menu a.item:hover {
.ui.secondary.pointing.menu .dropdown.item:hover {
color: var(--color-text-dark);
}

.ui.tabular.menu .active.item,
.ui.secondary.pointing.menu .active.item,
.resize-for-semibold::before {
font-weight: var(--font-weight-semibold);
}

.resize-for-semibold::before {
content: attr(data-text);
visibility: hidden;
display: block;
height: 0;
}

.ui.header {
color: var(--color-text);
}
Expand Down
1 change: 1 addition & 0 deletions web_src/css/repo/header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
flex-flow: row wrap;
justify-content: space-between;
gap: 0.5rem;
margin-bottom: 4px;
}

.repo-header .flex-item {
Expand Down
19 changes: 19 additions & 0 deletions web_src/js/webcomponents/overflow-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,25 @@ window.customElements.define('overflow-menu', class extends HTMLElement {
});

init() {
// for horizontal menus where fomantic boldens active items, prevent this bold text from
// enlarging the menu's active item replacing the text node with a div that renders a
// invisible pseudo-element that enlarges the box.
if (this.matches('.ui.secondary.pointing.menu, .ui.tabular.menu')) {
for (const item of this.querySelectorAll('.item')) {
for (const child of item.childNodes) {
if (child.nodeType === Node.TEXT_NODE) {
const text = child.textContent.trim(); // whitespace is insignificant inside flexbox
if (!text) continue;
const span = document.createElement('span');
span.classList.add('resize-for-semibold');
span.setAttribute('data-text', text);
span.textContent = text;
child.replaceWith(span);
}
}
}
}

// ResizeObserver triggers on initial render, so we don't manually call `updateItems` here which
// also avoids a full-page FOUC in Firefox that happens when `updateItems` is called too soon.
this.resizeObserver = new ResizeObserver((entries) => {
Expand Down