Skip to content

Only log error when tag sync fails #29295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Only log error when tag sync fails #29295

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8b4785e
Avoid migrate linux failure
lunny Feb 21, 2024
f2b29dd
Fix sha1
lunny Feb 21, 2024
651cbf5
Follow wxiaoguang's suggestion
lunny Feb 22, 2024
e42f75f
Merge branch 'main' into lunny/avoid_linux_migrate_failure
lunny Feb 22, 2024
41f6370
Update modules/repository/repo.go
lunny Feb 22, 2024
14aa91e
Update modules/repository/repo.go
wxiaoguang Feb 22, 2024
ddcf38b
Merge branch 'main' into lunny/avoid_linux_migrate_failure
GiteaBot Feb 22, 2024
60bb69d
Merge branch 'main' into lunny/avoid_linux_migrate_failure
GiteaBot Feb 22, 2024
464f4c5
Merge branch 'main' into lunny/avoid_linux_migrate_failure
GiteaBot Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/repository/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,9 @@ func SyncReleasesWithTags(ctx context.Context, repo *repo_model.Repository, gitR
}

if err := PushUpdateAddTag(ctx, repo, gitRepo, tagName, sha1, refname); err != nil {
return fmt.Errorf("unable to PushUpdateAddTag: %q to Repo[%d:%s/%s]: %w", tagName, repo.ID, repo.OwnerName, repo.Name, err)
// sometimes, some tags will be sync failed. i.e. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tag/?h=v2.6.11
// this is a tree object, not a tag object which created before git
log.Error("unable to PushUpdateAddTag: %q to Repo[%d:%s/%s]: %v", tagName, repo.ID, repo.OwnerName, repo.Name, err)
}

return nil
Expand Down