Skip to content

Make cross-reference issue links work in markdown documents again #28682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

brechtvl
Copy link
Contributor

@brechtvl brechtvl commented Jan 2, 2024

In #26365 issue references were disabled entirely for documents, intending to match GitHub behavior. However cross-references do appear to work in documents on GitHub.

This is useful for example to write release notes in a markdown document and reference issues. While the simpler syntax may create links when not intended, hopefully the cross-reference syntax is unique enough to avoid it.

In go-gitea#26365 issue references were disabled entirely for documents, intending
to match GitHub behavior. However cross-references do appear to work in
documents on GitHub.

This is useful for example to write release notes in a markdown document
and reference issues. While the simpler syntax may create links when not
intended, hopefully the cross-reference syntax is unique enough to avoid it.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 2, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 2, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 3, 2024
@lunny lunny merged commit 12c0487 into go-gitea:main Jan 3, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Jan 3, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 4, 2024
* giteaofficial/main:
  Normalize oauth email username (go-gitea#28561)
  Fix wrapping of label list (go-gitea#28684)
  Fix grammar in `actions.variables.id_not_exist` (en-US) (go-gitea#28680)
  Fix grammar issues on the repository Actions page (en-US) (go-gitea#28679)
  Fix tooltip of variable edit button (go-gitea#28681)
  Make cross-reference issue links work in markdown documents again (go-gitea#28682)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
…-gitea#28682)

In go-gitea#26365 issue references were disabled entirely for documents,
intending to match GitHub behavior. However cross-references do appear
to work in documents on GitHub.

This is useful for example to write release notes in a markdown document
and reference issues. While the simpler syntax may create links when not
intended, hopefully the cross-reference syntax is unique enough to avoid
it.
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
…-gitea#28682)

In go-gitea#26365 issue references were disabled entirely for documents,
intending to match GitHub behavior. However cross-references do appear
to work in documents on GitHub.

This is useful for example to write release notes in a markdown document
and reference issues. While the simpler syntax may create links when not
intended, hopefully the cross-reference syntax is unique enough to avoid
it.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants