Fix session key conflict with database keyword #28613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
delvh
approved these changes
Dec 25, 2023
GiteaBot
added
lgtm/need 1
delvh
added
type/testing
issue/regression
|
https://github.com/go-gitea/gitea/actions/runs/7322079180/job/19943180180#step:8:1216 |
wolfogre
approved these changes
Dec 27, 2023
GiteaBot
added
lgtm/done
wolfogre
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 29, 2023
* giteaofficial/main: [skip ci] Updated translations via Crowdin switch destination directory for apt signing keys (go-gitea#28639) Extend description for ARTIFACT_RETENTION_DAYS (go-gitea#28626) Refactor timeutil package (go-gitea#28623) Refactor some legacy code and remove unused code (go-gitea#28622) Remove unnecessary syncbranchToDB with tests (go-gitea#28624) Do not set `Accept` header twice (go-gitea#28598) [skip ci] Updated translations via Crowdin fix wrong link in user and organization profile when using relative url (go-gitea#28617) Add get actions runner registration token for API routes, repo, org, user and global level (go-gitea#27144) Fix session key conflict with database keyword (go-gitea#28613)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
This is a regression from go-gitea#28220 . `builder.Cond` will not add `` ` `` automatically but xorm method `Get/Find` adds `` ` ``. This PR also adds tests to prevent the method from being implemented incorrectly. The tests are added in `integrations` to test every database.
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
This is a regression from go-gitea#28220 . `builder.Cond` will not add `` ` `` automatically but xorm method `Get/Find` adds `` ` ``. This PR also adds tests to prevent the method from being implemented incorrectly. The tests are added in `integrations` to test every database.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression from #28220 .
builder.Condwill not add`automatically but xorm methodGet/Findadds`.This PR also adds tests to prevent the method from being implemented incorrectly. The tests are added in
integrationsto test every database.