Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 26, 2023

This PR removed drone file and cherry pick the release workflow from main branch but removed docker latest and 1 tags, Only keep 1.x and 1.x.x tags.

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Nov 26, 2023
@GiteaBot GiteaBot added this to the 1.20.6 milestone Nov 26, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 26, 2023
@techknowlogick
Copy link
Member

some makefile changes are also required

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 26, 2023
@lunny
Copy link
Member Author

lunny commented Nov 26, 2023

some makefile changes are also required

Which changes? Could you send some commits?

@jolheiser
Copy link
Member

From what I can tell, the changes for GHA are already in the 1.20 version of the Makefile, and a comparison of other commits made to e.g. the 1.21 branch only shows some updates to linting actions etc.
Are those required here as well?

@techknowlogick
Copy link
Member

@jolheiser ah, I guess I backported them already lol

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) November 28, 2023 00:47
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 28, 2023
@techknowlogick techknowlogick merged commit 1e9a765 into go-gitea:release/v1.20 Nov 28, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 28, 2023
@lunny lunny deleted the release_actions branch November 28, 2023 01:12
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants