Fix activity type match in matchPullRequestEvent (#25746)
#25797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#25736 Caused by go-gitea#24048 Right now we only check the activity type for `pull_request` event when `types` is specified or there are no `types` and filter. If a workflow only specifies filters but no `types` like this: ``` on: pull_request: branches: [main] ``` the workflow will be triggered even if the activity type is not one of `[opened, reopened, sync]`. We need to check the activity type in this case. Co-authored-by: Giteabot <[email protected]>
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Jul 10, 2023
GiteaBot
added
lgtm/need 1
KN4CK3R
approved these changes
Jul 10, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Codeberg-org
pushed a commit
to Codeberg-org/gitea
that referenced
this pull request
Jul 12, 2023
…o-gitea#25797) Backport go-gitea#25746 Fix go-gitea#25736 Caused by go-gitea#24048 Right now we only check the activity type for `pull_request` event when `types` is specified or there are no `types` and filter. If a workflow only specifies filters but no `types` like this: ``` on: pull_request: branches: [main] ``` the workflow will be triggered even if the activity type is not one of `[opened, reopened, sync]`. We need to check the activity type in this case. Co-authored-by: Giteabot <[email protected]> (cherry picked from commit bd1946e)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #25746
Fix #25736
Caused by #24048
Right now we only check the activity type for
pull_requestevent whentypesis specified or there are notypesand filter. If a workflow only specifies filters but notypeslike this:the workflow will be triggered even if the activity type is not one of
[opened, reopened, sync]. We need to check the activity type in this case.