Skip to content

enhancement of compare feature #25322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

a1012112796
Copy link
Member

@a1012112796 a1012112796 commented Jun 17, 2023

  1. add three compare modes instead of single mode, (that's like gitub), they are:

TIP: Compare mode was deteched by the compare link format.

a: Compare in same repository: will only show branch/tags dropdown, wich used to compare or create pull request in same repo.

image

image

b: Compare across repositorys which will not only show branch/tags dropdown, but also show repository dropdown, by default will single show fork repository of this repo in this list, but will load more repositorys if you entry a word in filter box.

image

image

c: Compare with repository in other service, a new mode which github not suport also :), in this mode, the head repo select box will be replaced with a repo url entry box, you can entry a git repo link to other website, then you can comare with it.

image

  • TODO: will suport creating pull request from repository in other service in future, now only support compare
  • note: To prevent to much time cost, has add --depth=100 as a limit.
  1. show a single error log instead of a 404 page when the head repo or user, the head or base ref
    is not exist. then user still can choose other option easyly.

image

image

1. add three compare modes instead of single mode,
(that's like gitub)

they are:

a: `Compare in same repository`: will only show
branch/tags dropdown, wich used to compare or
create pull request in same repo.

b: `Compare across repositorys` which will not
only show branch/tags dropdown, but also show
repository dropdown, by default will single
show fork repository of this repo in this list,
but will load more repositorys if you entry a
word in filter box.

c: `Compare with repository in other service`,
a new mode which github not suport also :),
in this mode, the head repo select box will be
replaced with a repo url entry box, you can entry
a git repo link to other website, then you can
comare with it.

TODO: will suport creating pull request from repository
in other service in future, now only support compare

To prevent to much time cost, has add
`--depth=100` as a limit.

2. show a single error log instead of a `404 page`
when the head repo or user, the head or base ref
is not exist. then user still can choose other option easyly.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 17, 2023
@a1012112796 a1012112796 added type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Jun 17, 2023
@delvh
Copy link
Member

delvh commented Jun 17, 2023

Regarding c):
What about calling it Compare with external repo(sitory) instead?

@lunny
Copy link
Member

lunny commented Jun 17, 2023

1 and 2 could be merged? And the 4) compare two repositories without fork relation on the same site.

@delvh delvh mentioned this pull request Sep 22, 2023
@a1012112796 a1012112796 marked this pull request as draft March 12, 2024 01:04
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Mar 13, 2024
splited from go-gitea#25322

- split branch/tags dropdownas two parts: repository
  dropdown and branch/tags dropdown. that's same
  with github.

- user can search any repository in repository search box.

- show a single error log instead of a 404 page when the
  head repo or user, the head or base ref is not exist.
  then user still can choose other option easyly.

Signed-off-by: a1012112796 <[email protected]>
@a1012112796 a1012112796 deleted the zzc/dev/compare branch March 14, 2024 01:13
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/translation type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants