-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
enhancement of compare feature #25322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add three compare modes instead of single mode, (that's like gitub) they are: a: `Compare in same repository`: will only show branch/tags dropdown, wich used to compare or create pull request in same repo. b: `Compare across repositorys` which will not only show branch/tags dropdown, but also show repository dropdown, by default will single show fork repository of this repo in this list, but will load more repositorys if you entry a word in filter box. c: `Compare with repository in other service`, a new mode which github not suport also :), in this mode, the head repo select box will be replaced with a repo url entry box, you can entry a git repo link to other website, then you can comare with it. TODO: will suport creating pull request from repository in other service in future, now only support compare To prevent to much time cost, has add `--depth=100` as a limit. 2. show a single error log instead of a `404 page` when the head repo or user, the head or base ref is not exist. then user still can choose other option easyly.
Regarding |
1 and 2 could be merged? And the 4) compare two repositories without fork relation on the same site. |
lunny
reviewed
Jun 17, 2023
Signed-off-by: a1012112796 <[email protected]>
Closed
Signed-off-by: a1012112796 <[email protected]>
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Mar 13, 2024
splited from go-gitea#25322 - split branch/tags dropdownas two parts: repository dropdown and branch/tags dropdown. that's same with github. - user can search any repository in repository search box. - show a single error log instead of a 404 page when the head repo or user, the head or base ref is not exist. then user still can choose other option easyly. Signed-off-by: a1012112796 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
modifies/translation
type/enhancement
An improvement of existing functionality
type/proposal
The new feature has not been accepted yet but needs to be discussed first.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIP: Compare mode was deteched by the compare link format.
a:
Compare in same repository
: will only show branch/tags dropdown, wich used to compare or create pull request in same repo.b:
Compare across repositorys
which will not only show branch/tags dropdown, but also show repository dropdown, by default will single show fork repository of this repo in this list, but will load more repositorys if you entry a word in filter box.c:
Compare with repository in other service
, a new mode which github not suport also :), in this mode, the head repo select box will be replaced with a repo url entry box, you can entry a git repo link to other website, then you can comare with it.--depth=100
as a limit.404 page
when the head repo or user, the head or base refis not exist. then user still can choose other option easyly.