Skip to content

Add test for api team organization #24699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 13, 2023
Merged

Add test for api team organization #24699

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
03e103e
Add test for api team orgnization
lunny May 13, 2023
d0b4b4a
Fix test
lunny May 13, 2023
d9f9668
Merge branch 'main' into lunny/add_team_org_test
lunny May 13, 2023
0c9561c
Merge branch 'main' into lunny/add_team_org_test
GiteaBot May 13, 2023
3f1b511
Merge branch 'main' into lunny/add_team_org_test
GiteaBot May 13, 2023
2ee2d6a
Merge branch 'main' into lunny/add_team_org_test
GiteaBot May 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/integration/api_team_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ func TestAPITeam(t *testing.T) {

teamUser := unittest.AssertExistsAndLoadBean(t, &organization.TeamUser{ID: 1})
team := unittest.AssertExistsAndLoadBean(t, &organization.Team{ID: teamUser.TeamID})
org := unittest.AssertExistsAndLoadBean(t, &organization.Organization{ID: teamUser.OrgID})
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: teamUser.UID})

session := loginUser(t, user.Name)
Expand All @@ -40,6 +41,7 @@ func TestAPITeam(t *testing.T) {
DecodeJSON(t, resp, &apiTeam)
assert.EqualValues(t, team.ID, apiTeam.ID)
assert.Equal(t, team.Name, apiTeam.Name)
assert.EqualValues(t, convert.ToOrganization(db.DefaultContext, org), apiTeam.Organization)

// non team member user will not access the teams details
teamUser2 := unittest.AssertExistsAndLoadBean(t, &organization.TeamUser{ID: 3})
Expand All @@ -58,7 +60,7 @@ func TestAPITeam(t *testing.T) {
session = loginUser(t, user.Name)
token = getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeAdminOrg)

org := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 6})
org = unittest.AssertExistsAndLoadBean(t, &organization.Organization{ID: 6})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why user -> organization?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why user -> organization?

The previous org is a *User, now since org has been declared, so here we should use *Organization as org.


// Create team.
teamToCreate := &api.CreateTeamOption{
Expand Down