Skip to content

Fix cases.Title crash for concurrency #23885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Fix cases.Title crash for concurrency #23885

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d70f79b
fix
wxiaoguang Apr 3, 2023
df63b5a
Merge branch 'main' into fix-title-crash
jolheiser Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions modules/util/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,19 +186,16 @@ func ToUpperASCII(s string) string {
return string(b)
}

var (
titleCaser = cases.Title(language.English)
titleCaserNoLower = cases.Title(language.English, cases.NoLower)
)

// ToTitleCase returns s with all english words capitalized
func ToTitleCase(s string) string {
return titleCaser.String(s)
// `cases.Title` is not thread-safe, do not use global shared variable for it
return cases.Title(language.English).String(s)
}

// ToTitleCaseNoLower returns s with all english words capitalized without lowercasing
// ToTitleCaseNoLower returns s with all english words capitalized without lower-casing
func ToTitleCaseNoLower(s string) string {
return titleCaserNoLower.String(s)
// `cases.Title` is not thread-safe, do not use global shared variable for it
return cases.Title(language.English, cases.NoLower).String(s)
}

func logError(msg string, args ...any) {
Expand Down