Skip to content

Conversation

@sillyguodong
Copy link
Contributor

@sillyguodong sillyguodong commented Mar 30, 2023

Backport #23655

Before, in project edit page, the cancel button is not work.

Screen.Recording.2023-03-23.at.17.55.08.mov
  1. The wrong classname cancel was added to the <a> tag. That classname caused the default click event of <a> tag to be cancelled. Because we have the following settings in the global. So I remove the classname cancel.

$(document).on('click', 'form .ui.cancel.button', (e) => {
e.preventDefault();
});

  1. Another change is that page will redirect to the previous page.
Screen.Recording.2023-03-23.at.19.15.23.mov

sillyguodong and others added 2 commits March 30, 2023 15:54
Before, in project edit page, the cancel button is not work.

https://user-images.githubusercontent.com/33891828/227182731-6478e29f-0e52-48c4-beb0-6a7d1dda6a1d.mov

1. The wrong classname `cancel` was added to the `<a>` tag. That
classname caused the default click event of `<a>` tag to be cancelled.
Because we have the following settings in the global. So I remove the
classname `cancel`.

https://github.com/go-gitea/gitea/blob/9be90a58754061171bbd5025d85d2b891364efd3/web_src/js/features/common-global.js#L325-L327

2. Another change is that page will redirect to the previous page.

https://user-images.githubusercontent.com/33891828/227187326-c653c6d6-9715-440f-a732-ba0a6f012c81.mov
# Conflicts:
#	templates/projects/new.tmpl
#	templates/repo/projects/new.tmpl
#	web_src/js/features/common-global.js
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 30, 2023
@lunny lunny added this to the 1.19.1 milestone Mar 30, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 30, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 30, 2023
@KN4CK3R KN4CK3R merged commit 863da7d into go-gitea:release/v1.19 Mar 30, 2023
@KN4CK3R KN4CK3R removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 30, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@sillyguodong sillyguodong deleted the release/v1.19 branch February 29, 2024 03:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants