Skip to content

Do not create commit graph for temporary repos (#23219) #23227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Mar 1, 2023

Backport #23219

When fetching remotes for conflict checking, skip unnecessary and potentially slow writing of commit graphs.

In a test with the Blender repository, this reduces conflict checking time for one pull request from about 2s to 0.1s.

When fetching remotes for conflict checking, skip unnecessary and
potentially slow writing of commit graphs.

In a test with the Blender repository, this reduces conflict checking
time for one pull request from about 2s to 0.1s.
@GiteaBot GiteaBot added performance/bigrepo Performance Issues affecting Big Repositories performance/speed performance issues with slow downs labels Mar 1, 2023
@techknowlogick techknowlogick added this to the 1.18.6 milestone Mar 1, 2023
@techknowlogick
Copy link
Member

CI failing due to TrustedCmdArgs not existing in 1.18

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 1, 2023
Copy link
Member

@yardenshoham yardenshoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't HAVE to backport this one, let's drop it

@delvh
Copy link
Member

delvh commented Mar 3, 2023

I'm fine with both options.

@techknowlogick techknowlogick deleted the backport-23219-v1.18 branch March 4, 2023 04:47
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. performance/bigrepo Performance Issues affecting Big Repositories performance/speed performance issues with slow downs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants