Skip to content

Create a lock abstract layer and remove old one #22176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 27 commits into from
Closed

Create a lock abstract layer and remove old one #22176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
0b6c92c
create a lock abstract layer and remove old one
lunny Dec 20, 2022
c87bc64
add setting
lunny Dec 20, 2022
845752d
Fix bug
lunny Dec 20, 2022
30d2023
comment year
lunny Dec 20, 2022
afe380f
Rename interface method
lunny Dec 20, 2022
11b7584
Fix bug
lunny Dec 20, 2022
3af650e
fix lint
lunny Dec 21, 2022
eef2002
Merge branch 'main' into lunny/lock_interface
lunny Dec 21, 2022
a788b44
Remove lock when Unlock
lunny Dec 21, 2022
a2281dd
Use moby/locker
lunny Dec 26, 2022
10a1fd8
Merge branch 'main' into lunny/lock_interface
lunny Dec 26, 2022
8ea63e4
Fix lint
lunny Dec 27, 2022
2618c52
Merge branch 'main' into lunny/lock_interface
lunny Dec 27, 2022
71208d7
Merge branch 'main' into lunny/lock_interface
lunny Dec 31, 2022
6ecafea
Merge branch 'main' into lunny/lock_interface
lunny Jan 1, 2023
5cc2850
Fix check
lunny Jan 1, 2023
8642873
lock key
lunny Jan 1, 2023
3a9df2e
Simple lock usage
lunny Jan 1, 2023
d2c3980
Update documentations
lunny Jan 10, 2023
e4a7e3b
Merge branch 'main' into lunny/lock_interface
lunny Jan 10, 2023
98dd8f4
Apply suggestions from code review
lunny Jan 10, 2023
02ef039
add tests
lunny Jan 11, 2023
980780f
Merge branch 'lunny/lock_interface' of github.com:lunny/gitea into lu…
lunny Jan 11, 2023
179beb8
Update documentations
lunny Jan 11, 2023
f3fa627
Merge branch 'main' into lunny/lock_interface
lunny Jan 11, 2023
985f433
merge main branch
lunny Jan 18, 2023
45a019d
Merge branch 'main' into lunny/lock_interface
lunny Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions assets/go-licenses.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions custom/conf/app.example.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2550,3 +2550,9 @@ ROUTER = console
;PROXY_URL =
;; Comma separated list of host names requiring proxy. Glob patterns (*) are accepted; use ** to match all hosts.
;PROXY_HOSTS =

;[sync]
;; Lock service type, could be memory or redis
;LOCK_SERVICE_TYPE = memory
;; Ignored by memory type, for redis, it likes "addrs=127.0.0.1:6379 db=0"
;LOCK_SERVICE_CONN_STR =
5 changes: 5 additions & 0 deletions docs/content/doc/advanced/config-cheat-sheet.en-us.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1314,6 +1314,11 @@ PROXY_URL = socks://127.0.0.1:1080
PROXY_HOSTS = *.github.com
```

## Sync (`sync`)

- `LOCK_SERVICE_TYPE`: **memory**: Lock service type, could be `memory` or `redis`
- `LOCK_SERVICE_CONN_STR`: **\<empty\>**: Ignored when `LOCK_SERVICE_TYPE` is `memory` type, for `redis`, it likes `addrs=127.0.0.1:6379 db=0`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this use the same connection string format which the other redis types are using?


## Other (`other`)

- `SHOW_FOOTER_BRANDING`: **false**: Show Gitea branding in the footer.
Expand Down
5 changes: 5 additions & 0 deletions docs/content/doc/advanced/config-cheat-sheet.zh-cn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,11 @@ PROXY_URL = socks://127.0.0.1:1080
PROXY_HOSTS = *.github.com
```

## Sync (`sync`)

- `LOCK_SERVICE_TYPE`: **memory**: 锁服务类型，可以是 `memory` 或 `redis`
- `LOCK_SERVICE_CONN_STR`: **\<empty\>**: 如果 `LOCK_SERVICE_TYPE` 是 `memory`，则忽略，如果是 `redis`，则支持形式如 `addrs=127.0.0.1:6379 db=0`

## Other (`other`)

- `SHOW_FOOTER_BRANDING`: 为真则在页面底部显示Gitea的字样。
Expand Down
2 changes: 2 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ require (
github.com/go-git/go-git/v5 v5.5.2
github.com/go-ldap/ldap/v3 v3.4.4
github.com/go-redis/redis/v8 v8.11.5
github.com/go-redsync/redsync/v4 v4.7.1
github.com/go-sql-driver/mysql v1.7.0
github.com/go-swagger/go-swagger v0.30.3
github.com/go-testfixtures/testfixtures/v3 v3.8.1
Expand Down Expand Up @@ -73,6 +74,7 @@ require (
github.com/mholt/archiver/v3 v3.5.1
github.com/microcosm-cc/bluemonday v1.0.21
github.com/minio/minio-go/v7 v7.0.46
github.com/moby/locker v1.0.1
github.com/msteinert/pam v1.1.0
github.com/nfnt/resize v0.0.0-20180221191011-83c6a9932646
github.com/niklasfasching/go-org v1.6.5
Expand Down
Loading