Skip to content

Add wording about keeping PRs up-to-date in CONTRIBUTING.md #21468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 15, 2022
Merged

Add wording about keeping PRs up-to-date in CONTRIBUTING.md #21468

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
893492f
Add wording about keeping PRs up-to-date in CONTRIBUTING.md
yardenshoham Oct 15, 2022
16a66f4
Break line
yardenshoham Oct 15, 2022
c789b37
Fix typo
yardenshoham Oct 15, 2022
f755db2
Update CONTRIBUTING.md
wxiaoguang Oct 15, 2022
2dcc120
Update CONTRIBUTING.md
wxiaoguang Oct 15, 2022
82f3b73
or -> nor
yardenshoham Oct 15, 2022
d95134f
Update CONTRIBUTING.md
6543 Oct 15, 2022
15e871b
make it same
6543 Oct 15, 2022
e36f677
Clarify commit message
yardenshoham Oct 15, 2022
59fe5c8
Merge branch 'main' into contributing-up-to-date
techknowlogick Oct 15, 2022
e0a0ac1
Unless there's a merge conflict
yardenshoham Oct 15, 2022
1360ab2
Break line
yardenshoham Oct 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,16 @@ If your PR could cause a breaking change you must add a BREAKING section to this

To explain how this could affect users and how to mitigate these changes.

Once code review starts on your PR, do not rebase nor squash your branch as it makes it
difficult to review the new changes. Only if there is a need, sync your branch by merging
the base branch into yours. Don't worry about merge commits messing up your tree as
the final merge process squashes all commits into one, with the visible commit message (first
line) being the PR title + PR index and description being the PR's first comment.

Once your PR gets the `lgtm/done` label, don't worry about keeping it up-to-date or breaking
builds (unless there's a merge conflict or a request is made by a maintainer to make
modifications). It is the maintainer team's responsibility from this point to get it merged.

## Styleguide

For imports you should use the following format (*without* the comments)
Expand Down