Fix repo API bug #2133
Merged
Fix repo API bug #2133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkcsoft
suggested changes
Jul 9, 2017
routers/api/v1/api.go
Outdated
There was a problem hiding this comment.
@bkcsoft Good catch, fixed.
bkcsoft
approved these changes
Jul 10, 2017
|
LGTM (just need rebase) |
tboerger
added
the
lgtm/need 1
sapk
approved these changes
Jul 10, 2017
sapk
reviewed
Jul 10, 2017
routers/api/v1/utils/utils.go
Outdated
There was a problem hiding this comment.
I would prefer the definition of a method like models.UserAccessLevel(ctx.User, repo) that check :
if ctx.User == nil { ... an return models.AccessLevel
Don't require token when not necessary
ethantkoenig
force-pushed
the
fix/repo_api
branch
from
91463b8 to
3f0efdc
Compare
|
Rebased to resolve conflict |
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't require authentication for some
GETAPI endpoints (e.g.GET /repos/:owner/:repo,GET /repos/:owner/:repo/issues, ...) whose corresponding Github endpoints do not require authentication.Also add integration tests for some of the affected endpoints.