Skip to content

Make time diff translatable #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2017
Merged

Make time diff translatable #2057

merged 1 commit into from
Jun 28, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jun 24, 2017

Changed also all other language files as otherwise they would be in broken shape

@pgaskin
Copy link
Contributor

pgaskin commented Jun 24, 2017

The other language files will end up being overwritten.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 24, 2017
@lafriks
Copy link
Member Author

lafriks commented Jun 24, 2017

I know, if not translated they will be in English but while not regenerated from crowdin at least they will not have %!s(MISSING) texts as I have removed %s from some places and added to others

@pgaskin
Copy link
Contributor

pgaskin commented Jun 24, 2017

OK

@lunny
Copy link
Member

lunny commented Jun 25, 2017

@lafriks but that's difficult to merge when we import from crowdin.

@lunny lunny added this to the 1.2.0 milestone Jun 25, 2017
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jun 25, 2017
@lafriks
Copy link
Member Author

lafriks commented Jun 25, 2017

Ok, I will revert that one commit but it will break time diff display for non-english languages while not imported form crowdin

@sondr3
Copy link
Contributor

sondr3 commented Jun 25, 2017

Probably off-topic, but just curious: why not just output the time as a ISO-formatted string in the HTML and use a JS library to convert it as mentioned in #1906?

@lafriks
Copy link
Member Author

lafriks commented Jun 25, 2017

Because it is sent also in email

@lafriks lafriks force-pushed the translatable_diff branch from f54f782 to dcfc8ca Compare June 25, 2017 09:53
@lafriks
Copy link
Member Author

lafriks commented Jun 25, 2017

@lunny done

@lafriks lafriks force-pushed the translatable_diff branch from dcfc8ca to 24d8f22 Compare June 25, 2017 10:49
@lunny
Copy link
Member

lunny commented Jun 25, 2017

@sondr3 and also, we need a server locale config item.

@lunny
Copy link
Member

lunny commented Jun 26, 2017

LGTM, This maybe broken other languages UI until they upload the newest translations.

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 26, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 27, 2017
@lunny lunny merged commit 32fc44a into go-gitea:master Jun 28, 2017
@lafriks lafriks deleted the translatable_diff branch June 30, 2017 07:35
@lunny lunny added the type/enhancement An improvement of existing functionality label Aug 25, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lafriks @pgaskin @lunny @sondr3 @appleboy @tboerger