Skip to content

Make blue really blue #19758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

wxiaoguang
Copy link
Contributor

The var(--color-primary) shouldn't be used for color blue, otherwise the blue becomes green in some themes.

@wxiaoguang wxiaoguang added this to the 1.17.0 milestone May 19, 2022
@wxiaoguang wxiaoguang added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 19, 2022

a {
color: inherit !important;

&:hover {
color: var(--color-primary-dark-1) !important;
color: #3876b3 !important;
Copy link
Member

@6543 6543 May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should move this into css var ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not this time. It just follows the red above.

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 19, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 19, 2022
@silverwind
Copy link
Member

silverwind commented May 19, 2022

There's a number of buttons in templates that use blue instead of primary, so these should regress to blue in arc-green after this change. I think these classes need to be renamed here as well.

@zeripath
Copy link
Contributor

There's a number of buttons in templates that use blue instead of primary, so these should regress to blue in arc-green after this change. I think these classes need to be renamed here as well.

There are 95 results in 62 *.tmpl files...

@wxiaoguang
Copy link
Contributor Author

There's a number of buttons in templates that use blue instead of primary, so these should regress to blue in arc-green after this change. I think these classes need to be renamed here as well.

Will you propose a PR to replace this one? Then close this one.

@zeripath
Copy link
Contributor

zeripath commented May 19, 2022

I have a feeling that a simple search and replace will work fine


yup having just done this on a pull of this PR I think that's correct.

@wxiaoguang
Copy link
Contributor Author

I'm open, this PR can be edited directly, or accept new PRs for it.

@silverwind
Copy link
Member

I'll have a look.

@silverwind
Copy link
Member

#19763

@silverwind silverwind closed this May 19, 2022
@wxiaoguang wxiaoguang deleted the fix-color-blue branch May 20, 2022 03:20
@wxiaoguang wxiaoguang removed this from the 1.17.0 milestone Jun 12, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants