Fix contrib/upgrade.sh
#19222
Merged
Fix contrib/upgrade.sh
#19222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eg when aborting the downloads
user facing variables first, definitions next, statements last
wxiaoguang
approved these changes
Mar 27, 2022
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Mar 27, 2022
GiteaBot
added
lgtm/done
zeripath
added
the
topic/build
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* fix idempotency of script (eg when aborting the downloads) * improve readability (user facing variables first, definitions next, statements last) * improve dependency checks * fix ignored $giteaversion variable * more logging * print usage string on incorrect usage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
..yes, it still passes shellcheck ;)