Skip to content

Set OpenGraph title to DisplayName in profile pages #19206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2022
Merged

Set OpenGraph title to DisplayName in profile pages #19206

merged 2 commits into from
Mar 25, 2022

Conversation

catdevnull
Copy link
Contributor

@catdevnull catdevnull commented Mar 24, 2022 •
edited
Loading

Before:

A screenshot of a Telegram message linking to a Gitea profile page that only shows the profile short name

After:

A screenshot of a Telegram message linking to a Gitea profile page that shows the profile's full name

Running in https://gitea.nulo.in

@lunny lunny added the type/enhancement An improvement of existing functionality label Mar 25, 2022
@lunny lunny added this to the 1.17.0 milestone Mar 25, 2022
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Mar 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #19206 (bb1fcd9) into main (49c5fc5) will decrease coverage by 0.05%.
The diff coverage is 38.71%.

@@            Coverage Diff             @@
##             main   #19206      +/-   ##
==========================================
- Coverage   46.55%   46.50%   -0.06%     
==========================================
  Files         856      856              
  Lines      123018   123182     +164     
==========================================
+ Hits        57277    57283       +6     
- Misses      58814    58960     +146     
- Partials     6927     6939      +12
Impacted Files Coverage Δ
cmd/admin.go 0.00% <0.00%> (ø)
cmd/hook.go 7.11% <0.00%> (ø)
cmd/serv.go 2.39% <0.00%> (ø)
cmd/web_acme.go 0.00% <0.00%> (ø)
models/asymkey/ssh_key_deploy.go 55.55% <ø> (+1.13%) ⬆️
models/helper_environment.go 100.00% <ø> (ø)
modules/context/permission.go 25.39% <0.00%> (ø)
modules/doctor/checkOldArchives.go 22.85% <0.00%> (ø)
modules/doctor/fix16961.go 35.06% <0.00%> (ø)
modules/doctor/mergebase.go 10.25% <0.00%> (ø)
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fe764b...bb1fcd9. Read the comment docs.

@lafriks lafriks merged commit f36701c into go-gitea:main Mar 25, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 26, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6427488 
* giteaofficial/main:
  Check go and nodejs version by go.mod and package.json (go-gitea#19197)
  Add `ContextUser` to http request context (go-gitea#18798)
  Set OpenGraph title to DisplayName in profile pages (go-gitea#19206)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@catdevnull @lafriks
Set OpenGraph title to DisplayName in profile pages (go-gitea#19206)
c68ad4c 
Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@Gusted Gusted Gusted approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@catdevnull @codecov-commenter @lunny @lafriks @Gusted @GiteaBot