Skip to content

Require token before checking membership/ownership #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2017
Merged

Require token before checking membership/ownership #1905

merged 1 commit into from
Jun 7, 2017

Conversation

@ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Jun 7, 2017 •
edited
Loading

Call the reqToken() handler before calling the reqOrgMembership() or reqOrgOwnership() handlers. Failing to do so results in a 500 for unauthenticated users (see error from #1899)

@andreynering
Copy link
Contributor

andreynering commented Jun 7, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 7, 2017
@andreynering andreynering added modifies/api This PR adds API routes or modifies them type/bug labels Jun 7, 2017
@andreynering andreynering added this to the 1.2.0 milestone Jun 7, 2017
@lafriks
Copy link
Member

lafriks commented Jun 7, 2017

LGTM

@lafriks
Copy link
Member

lafriks commented Jun 7, 2017

Make LG-TM work

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 7, 2017
@andreynering andreynering merged commit 65cf6cc into go-gitea:master Jun 7, 2017
@ethantkoenig ethantkoenig deleted the fix/org_api_auth branch June 8, 2017 14:21
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ethantkoenig @andreynering @lafriks @tboerger