Don't clean up hardcoded tmp
#18983
Merged
Don't clean up hardcoded tmp
#18983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gusted
approved these changes
Mar 2, 2022
GiteaBot
added
the
lgtm/need 1
6543
approved these changes
Mar 2, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 3, 2022
* giteaofficial/main: Don't clean up hardcoded `tmp` (go-gitea#18983) git backend ignore replace objects (go-gitea#18979) Improve the deletion of issue (go-gitea#18945) Add note to GPG key response if user has no keys (go-gitea#18961) adds restore docs for docker based instances (go-gitea#18844) Refactor admin user filter query parameters (go-gitea#18965)
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Mar 3, 2022
* main: ignore missing comment for user notifications (go-gitea#18954) allow overwrite artifacts for github releases (go-gitea#18987) fix & refactor (go-gitea#18973) Don't clean up hardcoded `tmp` (go-gitea#18983) git backend ignore replace objects (go-gitea#18979) Improve the deletion of issue (go-gitea#18945) Add note to GPG key response if user has no keys (go-gitea#18961) adds restore docs for docker based instances (go-gitea#18844) Refactor admin user filter query parameters (go-gitea#18965)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Don't clean up hardcoded `tmp`. * Fixed import.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the hardcoded deletion of
tmpinto two cleanups for both temporary paths.Now both paths are cleaned up too if a user has configured different paths. We do that too in
gitea/docker/root/etc/templates/app.ini
Lines 7 to 11 in efd10f1
PPROF_DATA_PATH(data/tmp/pprof) is not cleaned up anymore. But that may be better because it may contains useful debugging info. And most users don't have pprof enabled anyway.